After adding deleting fonctionality for apk

This commit is contained in:
Your Name 2026-11-04 16:23:17 +02:00
parent 16e896005c
commit dff2730edc
10 changed files with 154 additions and 6 deletions

View File

@ -198,6 +198,20 @@ export async function adminRetire(req: AuthRequest, res: Response): Promise<void
} }
} }
export async function adminDelete(req: AuthRequest, res: Response): Promise<void> {
try {
res.json(
await mobileAppReleaseService.hardDelete(String(req.params.id), {
userId: req.user!.userId,
ipAddress: req.ip || undefined,
userAgent: req.get('user-agent') || undefined,
})
);
} catch (e) {
sendError(res, e, 'Delete failed');
}
}
export async function adminStats(_req: AuthRequest, res: Response): Promise<void> { export async function adminStats(_req: AuthRequest, res: Response): Promise<void> {
try { try {
res.json(await mobileAppReleaseService.getStats()); res.json(await mobileAppReleaseService.getStats());

View File

@ -310,6 +310,24 @@ export async function findLatestPublished(
return rows[0] ? mapRelease(rows[0]) : null; return rows[0] ? mapRelease(rows[0]) : null;
} }
/** Deletes telemetry events for a release (hard delete cleanup). */
export async function deleteEventsForRelease(releaseId: string): Promise<number> {
const rows = await query<Array<{ id: string }>>(
`DELETE FROM mobile_app_release_events WHERE release_id = $1 RETURNING id`,
[releaseId]
);
return rows.length;
}
/** Permanently removes a release row. Returns false if not found. */
export async function deleteRelease(id: string): Promise<boolean> {
const rows = await query<Array<{ id: string }>>(
`DELETE FROM mobile_app_releases WHERE id = $1 RETURNING id`,
[id]
);
return Boolean(rows[0]);
}
export async function findHighestMandatoryPublished( export async function findHighestMandatoryPublished(
platform: MobilePlatform, platform: MobilePlatform,
channel: MobileChannel channel: MobileChannel

View File

@ -712,6 +712,13 @@ router.post(
validateParams(mobileReleaseIdParamSchema), validateParams(mobileReleaseIdParamSchema),
mobileAppReleaseController.adminRetire mobileAppReleaseController.adminRetire
); );
router.delete(
'/admin/mobile-releases/:id',
requireRoles('admin'),
requirePermissions('admin.mobile_releases.manage'),
validateParams(mobileReleaseIdParamSchema),
mobileAppReleaseController.adminDelete
);
router.get('/admin/solo-encouragement/config', requireRoles('admin'), requirePermissions('settings.admin'), soloEncouragementController.getAdminConfig); router.get('/admin/solo-encouragement/config', requireRoles('admin'), requirePermissions('settings.admin'), soloEncouragementController.getAdminConfig);
router.patch('/admin/solo-encouragement/config', requireRoles('admin'), requirePermissions('settings.admin'), validateBody(soloEncouragementConfigBodySchema), soloEncouragementController.updateAdminConfig); router.patch('/admin/solo-encouragement/config', requireRoles('admin'), requirePermissions('settings.admin'), validateBody(soloEncouragementConfigBodySchema), soloEncouragementController.updateAdminConfig);

View File

@ -17,7 +17,12 @@ import {
sha256File, sha256File,
} from './apkStorageService'; } from './apkStorageService';
import * as repo from '../repositories/mobileAppReleaseRepository'; import * as repo from '../repositories/mobileAppReleaseRepository';
import { recordUploadedFile, FILE_INTEGRITY_ROOTS } from './fileIntegrityService'; import {
recordUploadedFile,
FILE_INTEGRITY_ROOTS,
} from './fileIntegrityService';
import * as fileIntegrityRepository from '../repositories/fileIntegrityRepository';
import * as auditLogRepository from '../repositories/auditLogRepository';
import type { import type {
MobileAppRelease, MobileAppRelease,
MobileChannel, MobileChannel,
@ -372,6 +377,70 @@ export async function retire(id: string) {
return updated; return updated;
} }
/**
* Permanently deletes a release: APK file on disk, FIM snapshot, events, DB row.
* Blocks deletion of the current highest published release for that platform/channel
* (would leave clients without an update target).
*/
export async function hardDelete(
id: string,
actor?: { userId: string; ipAddress?: string; userAgent?: string }
): Promise<{ deleted: true; versionCode: number; versionName: string }> {
const release = await getRelease(id);
if (release.status === 'published') {
const latest = await repo.findLatestPublished(release.platform, release.channel);
if (latest && latest.id === release.id) {
throw new MobileReleaseError(
400,
'Cannot delete the current published release. Publish a newer build first, or suspend/retire this one.',
'MOBILE_RELEASE_IS_LATEST_PUBLISHED'
);
}
}
const storageKey = release.storageKey;
const eventsRemoved = await repo.deleteEventsForRelease(id);
const deleted = await repo.deleteRelease(id);
if (!deleted) throw new MobileReleaseError(404, 'Release not found');
removeApkIfExists(storageKey);
if (storageKey?.startsWith('published/')) {
try {
await fileIntegrityRepository.deleteSnapshot(
FILE_INTEGRITY_ROOTS.apkPublished,
`${id}.apk`
);
} catch (e) {
console.warn('[mobile-releases] FIM snapshot cleanup skipped:', e);
}
}
if (actor?.userId) {
await auditLogRepository.create({
userId: actor.userId,
action: 'mobile_release_deleted',
resourceType: 'mobile_app_release',
resourceId: id,
ipAddress: actor.ipAddress ?? null,
userAgent: actor.userAgent ?? null,
metadata: {
versionName: release.versionName,
versionCode: release.versionCode,
status: release.status,
storageKey,
eventsRemoved,
},
});
}
return {
deleted: true,
versionCode: release.versionCode,
versionName: release.versionName,
};
}
export type UpdateCheckResult = { export type UpdateCheckResult = {
updateAvailable: boolean; updateAvailable: boolean;
blocked: boolean; blocked: boolean;

View File

@ -66,10 +66,13 @@ The API reads the signing cert from APK Signature Scheme **v2/v3** (and JAR v1 w
4. Submit → Publish 4. Submit → Publish
5. Optionally set rollout % (5 / 20 / 50 / 100) and update policy (optional / recommended / mandatory) 5. Optionally set rollout % (5 / 20 / 50 / 100) and update policy (optional / recommended / mandatory)
### Suspend / rollback ### Suspend / rollback / delete
- **Suspend** or **retire** stops offering that APK to new checks - **Suspend** or **retire** stops offering that APK to new checks (file and DB row remain)
- Devices that already installed it **cannot** be downgraded; ship a higher `versionCode` hotfix instead - **Delete permanently** (`DELETE /admin/mobile-releases/:id`) removes the APK file on disk, FIM snapshot, related telemetry events, and the DB row
- Devices that already installed a deleted/retired build **keep the app** (Android cannot downgrade); ship a higher `versionCode` hotfix instead
- You **cannot** delete the current highest **published** release for that platform/channel — publish a newer build first, or suspend/retire it
- Prefer deleting older duplicates (same `versionName`, lower `versionCode`) after a newer published build exists
## Mobile client behaviour ## Mobile client behaviour

View File

@ -1,7 +1,7 @@
name: prediqo_mobile name: prediqo_mobile
description: "Tloto mobile app - prediction games and crypto wallet." description: "Tloto mobile app - prediction games and crypto wallet."
publish_to: 'none' publish_to: 'none'
version: 2.0.2+11 version: 2.0.2+12
environment: environment:
sdk: ^3.9.2 sdk: ^3.9.2

View File

@ -35,6 +35,7 @@ import { useAuth } from '../../shared/auth/AuthContext';
import { ScrollableTable } from '../../shared/components/ScrollableTable'; import { ScrollableTable } from '../../shared/components/ScrollableTable';
import { import {
createMobileRelease, createMobileRelease,
deleteMobileRelease,
getMobileReleaseStats, getMobileReleaseStats,
getMobileUpdateSettings, getMobileUpdateSettings,
listMobileReleases, listMobileReleases,
@ -207,11 +208,16 @@ export function MobileVersionsAdminPage() {
if (action === 'publish') return publishMobileRelease(id); if (action === 'publish') return publishMobileRelease(id);
if (action === 'suspend') return suspendMobileRelease(id); if (action === 'suspend') return suspendMobileRelease(id);
if (action === 'retire') return retireMobileRelease(id); if (action === 'retire') return retireMobileRelease(id);
if (action === 'delete') return deleteMobileRelease(id);
if (action === 'patch' && patch) return updateMobileRelease(id, patch); if (action === 'patch' && patch) return updateMobileRelease(id, patch);
throw new Error('Unknown action'); throw new Error('Unknown action');
}, },
onSuccess: (rel) => { onSuccess: (rel) => {
setSelected(rel); if (rel && typeof rel === 'object' && 'deleted' in rel && rel.deleted) {
setSelected(null);
} else if (rel && typeof rel === 'object' && 'id' in rel) {
setSelected(rel as MobileAppRelease);
}
setError(null); setError(null);
invalidate(); invalidate();
}, },
@ -454,6 +460,22 @@ export function MobileVersionsAdminPage() {
> >
{t('admin.mobileVersions.retire')} {t('admin.mobileVersions.retire')}
</Button> </Button>
<Button
color="error"
variant="outlined"
disabled={actionMut.isPending}
onClick={() => {
const ok = window.confirm(
t('admin.mobileVersions.deleteConfirm', {
version: detail.versionName,
code: detail.versionCode,
})
);
if (ok) actionMut.mutate({ action: 'delete', id: detail.id });
}}
>
{t('admin.mobileVersions.delete')}
</Button>
</Stack> </Stack>
</PermissionGate> </PermissionGate>
</Box> </Box>

View File

@ -162,6 +162,15 @@ export async function retireMobileRelease(id: string) {
return data; return data;
} }
export async function deleteMobileRelease(id: string) {
const { data } = await api.delete<{
deleted: true;
versionCode: number;
versionName: string;
}>(`/api/v1/admin/mobile-releases/${id}`);
return data;
}
export async function getMobileReleaseStats() { export async function getMobileReleaseStats() {
const { data } = await api.get<MobileReleaseStats>('/api/v1/admin/mobile-releases/stats'); const { data } = await api.get<MobileReleaseStats>('/api/v1/admin/mobile-releases/stats');
return data; return data;

View File

@ -1277,6 +1277,9 @@ export const en = {
publish: 'Publish', publish: 'Publish',
suspend: 'Suspend', suspend: 'Suspend',
retire: 'Retire', retire: 'Retire',
delete: 'Delete permanently',
deleteConfirm:
'Permanently delete {{version}} (#{{code}})? This removes the APK file and release record. Users who already installed this build keep the app; it can no longer be offered for download. The current highest published release cannot be deleted.',
previousVersion: 'Previous version', previousVersion: 'Previous version',
rollout: 'Rollout %', rollout: 'Rollout %',
rolloutHint: 'Percentage of devices that receive this release (deterministic by device id).', rolloutHint: 'Percentage of devices that receive this release (deterministic by device id).',

View File

@ -1295,6 +1295,9 @@ export const fr = {
publish: 'Publier', publish: 'Publier',
suspend: 'Suspendre', suspend: 'Suspendre',
retire: 'Retirer', retire: 'Retirer',
delete: 'Supprimer définitivement',
deleteConfirm:
'Supprimer définitivement {{version}} (#{{code}}) ? Cela efface le fichier APK et l’enregistrement. Les utilisateurs qui ont déjà installé cette build gardent l’app ; elle ne pourra plus être proposée au téléchargement. La release published la plus récente ne peut pas être supprimée.',
previousVersion: 'Version précédente', previousVersion: 'Version précédente',
rollout: 'Déploiement %', rollout: 'Déploiement %',
rolloutHint: 'Pourcentage d’appareils qui reçoivent cette version (déterministe par device id).', rolloutHint: 'Pourcentage d’appareils qui reçoivent cette version (déterministe par device id).',